fix: issue#62 strip auth key #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, this looks very nice, thanks for that! I will review on monday |
JanEbbing
reviewed
Feb 17, 2025
deepl-java/src/test/java/com/deepl/api/utils/StringUtilTest.java
Outdated
Show resolved
Hide resolved
timazhum
force-pushed
the
strip-auth-key
branch
from
00a1e54 to
b1f7887
Compare
|
Amended the commit, using |
leoncheng57
reviewed
Feb 18, 2025
leoncheng57
reviewed
Feb 18, 2025
|
Happy to merge this once Leon's comment is addressed :) thanks for your work! |
Fixing the issue raised in DeepLcom#62 Problem: auth key with leading / trailing whitespaces is throwing exceptions. For example, assigning the secret via `echo` leaves a trailing `\n`. Solution: strip input auth key as an input sanitization procedure Notice: Java 8 does not support `String.strip()`, while `String.trim()` does not support Unicode whitespaces. We anticipate ASCII only input and utilizing `trim()` for simplicity.
timazhum
force-pushed
the
strip-auth-key
branch
from
b1f7887 to
15b74df
Compare
✅ Addressed, thanks for all the feedback provided |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue raised in #62
Problem: auth key with leading / trailing whitespaces is throwing exceptions. For example, assigning the secret via
echoleaves a trailing\n.Solution: strip input auth key as an input sanitization procedure
Notice: Java 8 does not support
String.strip(), whileString.trim()does not support Unicode whitespaces. Therefore, using regex expressions for stripping.